fix: cookies.get should be able to filter domain #20471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zcbenz
force-pushed
the
fix-cookies-getall
branch
from
425fc29
to
8c20f62
Compare
deepak1556
approved these changes
Oct 8, 2019
|
Release Notes Persisted
|
|
I was unable to backport this PR to "7-0-x" cleanly; |
zcbenz
added a commit
that referenced
this pull request
Oct 9, 2019
* fix: use GetAllCookies when url is empty * test: get cookie without url
jkleinsc
pushed a commit
that referenced
this pull request
Oct 9, 2019
|
@zcbenz what about |
|
Yeah the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fix #20392.
This PR fixes a bug that wrong API was used when
urlis not specified, this bug was introduced when migrating to NetworkService APIs.Checklist
npm testpassesRelease Notes
Notes: Fix
cookies.getnot working whenurlis not specified in filter.